Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly computing loop iterations in BigDecimal#sqrt #280

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Correctly computing loop iterations in BigDecimal#sqrt #280

merged 1 commit into from
Dec 19, 2023

Conversation

z2-2z
Copy link
Contributor

@z2-2z z2-2z commented Dec 14, 2023

No description provided.

@mrkn mrkn merged commit 5843c89 into ruby:master Dec 19, 2023
46 of 47 checks passed
@mrkn
Copy link
Member

mrkn commented Dec 19, 2023

@z2-2z Thank you very much!

hsbt pushed a commit to hsbt/ruby that referenced this pull request Dec 25, 2023
@z2-2z @hsbt
[ruby/bigdecimal] Correctly computing loop iterations in
862dde5 
`BigDecimal#sqrt`
(ruby/bigdecimal#280)

ruby/bigdecimal@5843c89da4
hsbt pushed a commit to hsbt/ruby that referenced this pull request Dec 25, 2023
@z2-2z @hsbt
[ruby/bigdecimal] Correctly computing loop iterations in
34b991b 
`BigDecimal#sqrt`
(ruby/bigdecimal#280)

ruby/bigdecimal@5843c89da4
hsbt pushed a commit to hsbt/ruby that referenced this pull request Dec 25, 2023
@z2-2z @hsbt
[ruby/bigdecimal] Correctly computing loop iterations in
f2c1ac1 
`BigDecimal#sqrt`
(ruby/bigdecimal#280)

ruby/bigdecimal@5843c89da4
@hsbt
Copy link
Member

hsbt commented Dec 25, 2023 •
edited
Loading

This change break i686 environment https://github.com/ruby/ruby/actions/runs/7321152433/job/19941861006

  1)
  BigDecimal#sqrt returns square root of 0.9E-99999 with desired precision FAILED
  Expected "0.29999999999999999999993e-49999" =~ /\A0\.3E-49999\z/i
  to be truthy but was nil
  /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/sqrt_spec.rb:40:in `block (2 levels) in <top (required)>'
  /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/sqrt_spec.rb:5:in `<top (required)>'

@mrkn
Copy link
Member

mrkn commented Dec 25, 2023

@hsbt Did you compile the ruby you used with -msse2 -mfpmath=sse?

@mrkn
Copy link
Member

mrkn commented Dec 25, 2023

I'm interested in what is the cause of that failure, but I have no desire to continue full support for the i686 environment.

@hsbt
Copy link
Member

hsbt commented Jan 18, 2024

It's okay to drop support i686 platform because bigdecimal is bundled gems at Ruby 3.4. Now, support platform of bigdecimal gem is totally maintainer's convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z2-2z @mrkn @hsbt