Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3.1 parsing bug #324

Closed
stoodfarback opened this issue Dec 21, 2024 · 2 comments
Closed

3.3.1 parsing bug #324

stoodfarback opened this issue Dec 21, 2024 · 2 comments

Comments

@stoodfarback
Copy link

I've compacted the data as much as I could to have a small script to reproduce. It appears to happen when there's a quoted comma in a cell and a blank row after.

csv_data = <<~HEREDOC
  "one,"
  
  "three"
HEREDOC

pp(CSV.parse(csv_data))

output with csv gem 3.3.0

[["one,"], [], ["three"]]

output with csv gem 3.3.1

[["one,"], ["three"], ["three"]]

system info

> ruby -v
ruby 3.3.4 (2024-07-09 revision be1089c8ec) [x86_64-linux]
@kou kou closed this as completed in abf32b6 Dec 21, 2024
@kou
Copy link
Member

kou commented Dec 21, 2024

Thanks for your report. I'll release a new version.

FYI: @marshall-lee GH-312 introduced this.

@stoodfarback
Copy link
Author

Verified 3.3.2 fixes the bug for me.
Thank you for the fast update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants