Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:method: seems to generate wrong line no. #750

Closed
neko314 opened this issue Nov 26, 2019 · 3 comments · Fixed by #751
Closed

:method: seems to generate wrong line no. #750

neko314 opened this issue Nov 26, 2019 · 3 comments · Fixed by #751

Comments

@neko314
Copy link

neko314 commented Nov 26, 2019

Steps to reproduce

# sample.rb

1 class Sample
2
3  # :method: hoege
4
5 end

Run rdoc and open generated file .

image

Expected behavior

The documentation says line no is 5, but I think it's better 3.

@neko314 neko314 changed the title :method: seems to generate wrong Line no. :method: seems to generate wrong line no. Nov 26, 2019
@aycabta
Copy link
Member

aycabta commented Nov 27, 2019

Good catch, thank you for reporting! This is an important point to detect the definition position because I'll add a showing source code feature to IRB later. Please feel free to report other bugs or strange behaviors more too.

@neko314
Copy link
Author

neko314 commented Nov 28, 2019

Thank you for fixing it!
I’ll report when I find anything wrong. Actually... I want to make PR in that case, so I'll try.
Anyway, thanks so much.

@aycabta
Copy link
Member

aycabta commented Nov 28, 2019

Maybe I need full-time 1 week to fix this problem if it's before I became the RDoc maintainer. It's too difficult because it's a core problem of Ruby's parser. I hope you to get new technical powers and confidence but I guessed this isn't a good problem to gein confidence for you or all new contributors. Therefore, I fixed this issue on a priority basis.

Let you try to find new challenges and try to fix. I welcome your adventure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants