Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect environment using rails 5 system tests #208

Closed
kule opened this issue Oct 29, 2018 · 2 comments
Closed

Incorrect environment using rails 5 system tests #208

kule opened this issue Oct 29, 2018 · 2 comments
Milestone
2.1.0

Comments

@kule
Copy link

kule commented Oct 29, 2018

Just posting this incase someone else has this - I current gem doesn't appear to be threadsafe, when running the new rails system tests (with rspec) I'd consistently get failures when running the full test suite. Investigating with pry I'd find that the Settings object was showing the incorrect settings for the current environment - it's like it hadn't merged the current envs settings.

I created my own simplified version of RailsConfig using class instance variables which had the same issue, but storing the settings in Thread.current fixed the issue for me.
@pkuczynski
Copy link
Member

Maybe you would like to prepare a PR? I am not working with Ruby anymore for the last 3y... :(

@pkuczynski
Copy link
Member

With the changes from #230 this should not be an issue anymore. @kule would you like to test and confirm?

@pkuczynski pkuczynski added this to the 2.0.1 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@kule @pkuczynski