Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade go version 1.21 #116

Merged
merged 1 commit into from
Sep 6, 2023
Merged

chore: upgrade go version 1.21 #116

merged 1 commit into from
Sep 6, 2023

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Sep 6, 2023

Description

  • Updated for version to 1.21
  • Updated golangci-lint to 1.54.2
  • removed structcheck as it's not being maintained and is throwing false positives for structs with generics
  • fix depgaurd rules
  • added unparam and unconvert linters

Linear Ticket

Linear Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 merged commit 1f9dde1 into main Sep 6, 2023
6 checks passed
@cisse21 cisse21 deleted the chore.upgradeGoVersion branch September 6, 2023 11:22
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achettyiitr achettyiitr achettyiitr approved these changes

@atzoum atzoum atzoum approved these changes

Assignees
No one assigned
Labels
with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cisse21 @atzoum @achettyiitr