chore: add a docker resource for minio #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 79.13% 79.02% -0.12%
==========================================
Files 68 70 +2
Lines 5081 5172 +91
==========================================
+ Hits 4021 4087 +66
- Misses 859 879 +20
- Partials 201 206 +5
☔ View full report in Codecov by Sentry. |
lvrach
approved these changes
Oct 26, 2023
achettyiitr
reviewed
Oct 26, 2023
|
|
||
| func SetupMinio(pool *dockertest.Pool, d cleaner, opts ...func(*minioconfig.Config)) (*MinioResource, error) { | ||
| const ( | ||
| bucket = "rudder-saas" |
There was a problem hiding this comment.
Should we name it testbucket instead of RudderStack production bucket?
Suggested change
| bucket = "rudder-saas" | |
| bucket = "testbucket" |
achettyiitr
approved these changes
Oct 26, 2023
atzoum
force-pushed
the
chore.minioResource
branch
from
ee33a9f
to
af7811a
Compare
atzoum
force-pushed
the
chore.minioResource
branch
from
af7811a
to
4d3bdc9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standardising the way we are creating minio docker containers in our tests
Security