Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for pulsar proper startup #17

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: wait for pulsar proper startup #17

merged 1 commit into from
Apr 11, 2023

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Apr 11, 2023

Description

Pulsar's health check has been rewritten to ensure the default tenant/namespace is ready to receive read and write requests before the container is judged to be ready.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -2.04 ⚠️

Comparison is base (e7afeb1) 78.42% compared to head (ace24f0) 76.38%.

❗ Current head ace24f0 differs from pull request most recent head 1b8e473. Consider uploading reports for the commit 1b8e473 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   78.42%   76.38%   -2.04%     
==========================================
  Files          37       41       +4     
  Lines        2725     2837     +112     
==========================================
+ Hits         2137     2167      +30     
- Misses        487      564      +77     
- Partials      101      106       +5     
Impacted Files Coverage Δ
testhelper/docker/resource/pulsar.go 61.22% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum merged commit 154ff20 into main Apr 11, 2023
@atzoum atzoum deleted the fix.pulsarWait branch April 11, 2023 10:00
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants