Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mock config BE support for transformer #344

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

mihir20
Copy link
Contributor

@mihir20 mihir20 commented Feb 20, 2024

Description

Add support to mock config backend with transformer resource initialisation. This will allow tests to run independent of actual config backend. Test will not fail even if control plane is down.

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-804/mock-config-be-for-transformer-resource-in-go-kit

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 34.39%. Comparing base (fba3feb) to head (f8d5139).

Files Patch % Lines
...resource/transformer/transformer_backend_config.go 70.96% 7 Missing and 2 partials ⚠️
testhelper/httptest/httptest.go 72.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #344       +/-   ##
===========================================
- Coverage   79.53%   34.39%   -45.15%     
===========================================
  Files          86       47       -39     
  Lines        6627     3815     -2812     
===========================================
- Hits         5271     1312     -3959     
- Misses       1091     2380     +1289     
+ Partials      265      123      -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mihir20 mihir20 force-pushed the mihir/pipe-804 branch 23 times, most recently from 4212d82 to b15ec75 Compare February 21, 2024 13:16
.github/workflows/tests.yaml Show resolved Hide resolved
testhelper/docker/docker.go Outdated Show resolved Hide resolved
testhelper/httptest/httptest.go Outdated Show resolved Hide resolved
testhelper/httptest/httptest.go Outdated Show resolved Hide resolved
testhelper/httptest/httptest.go Outdated Show resolved Hide resolved
testhelper/docker/resource/transformer/transformer_test.go Outdated Show resolved Hide resolved
testhelper/docker/resource/transformer/transformer_test.go Outdated Show resolved Hide resolved
testhelper/docker/resource/transformer/transformer_test.go Outdated Show resolved Hide resolved
testhelper/docker/resource/transformer/transformer_test.go Outdated Show resolved Hide resolved
@mihir20 mihir20 force-pushed the mihir/pipe-804 branch 2 times, most recently from 1406317 to 482d8c7 Compare February 22, 2024 09:12
@mihir20 mihir20 enabled auto-merge (squash) February 23, 2024 12:19
@mihir20 mihir20 merged commit d48fc68 into main Feb 23, 2024
12 checks passed
@mihir20 mihir20 deleted the mihir/pipe-804 branch February 23, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants