-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add mock config BE support for transformer #344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihir20
force-pushed
the
mihir/pipe-804
branch
from
February 20, 2024 12:45
9292a8b
to
68400be
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
===========================================
- Coverage 79.53% 34.39% -45.15%
===========================================
Files 86 47 -39
Lines 6627 3815 -2812
===========================================
- Hits 5271 1312 -3959
- Misses 1091 2380 +1289
+ Partials 265 123 -142 ☔ View full report in Codecov by Sentry. |
mihir20
force-pushed
the
mihir/pipe-804
branch
23 times, most recently
from
February 21, 2024 13:16
4212d82
to
b15ec75
Compare
atzoum
reviewed
Feb 21, 2024
testhelper/docker/resource/transformer/transformer_backend_config.go
Outdated
Show resolved
Hide resolved
achettyiitr
reviewed
Feb 21, 2024
testhelper/docker/resource/transformer/transformer_backend_config.go
Outdated
Show resolved
Hide resolved
mihir20
force-pushed
the
mihir/pipe-804
branch
from
February 22, 2024 08:02
e5bab1b
to
1c77b0f
Compare
achettyiitr
reviewed
Feb 22, 2024
mihir20
force-pushed
the
mihir/pipe-804
branch
2 times, most recently
from
February 22, 2024 09:12
1406317
to
482d8c7
Compare
achettyiitr
approved these changes
Feb 22, 2024
atzoum
approved these changes
Feb 23, 2024
mihir20
force-pushed
the
mihir/pipe-804
branch
from
February 23, 2024 12:19
8bc0895
to
f8d5139
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to mock config backend with transformer resource initialisation. This will allow tests to run independent of actual config backend. Test will not fail even if control plane is down.
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-804/mock-config-be-for-transformer-resource-in-go-kit
Security