Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: close postgres db on cleanup #357

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: close postgres db on cleanup #357

merged 1 commit into from
Feb 27, 2024

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Feb 27, 2024

Description

Closing postgres sql.DB on cleanup to avoid resource leaks (debugging unexpected EOF errors in gha)

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (a9420ee) to head (d5aef5c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   79.65%   78.82%   -0.83%     
==========================================
  Files          91       82       -9     
  Lines        6788     6461     -327     
==========================================
- Hits         5407     5093     -314     
- Misses       1110     1116       +6     
+ Partials      271      252      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum merged commit 85f29b5 into main Feb 27, 2024
16 checks passed
@atzoum atzoum deleted the chore.closeResourceDB branch February 27, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants