Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additional helpers packages #416

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat: additional helpers packages #416

merged 5 commits into from
Apr 9, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Apr 8, 2024 •
edited
Loading

Description

Linear Ticket

  • Resolves PIPE-838, PIPE-839, PIPE-837, PIPE-920, PIPE-841

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the feat.additional-helpers branch 4 times, most recently from 7221a37 to 1b04292 Compare April 8, 2024 10:24
@achettyiitr achettyiitr mentioned this pull request Apr 8, 2024
Merged
1 task
@achettyiitr achettyiitr changed the title feat: additional of some helpers feat: additional helpers packages Apr 8, 2024
fracasula
fracasula approved these changes Apr 8, 2024
View reviewed changes
config/valueloader.go Outdated Show resolved Hide resolved
sanitize/sanitize.go Outdated Show resolved Hide resolved
sanitize/sanitize_test.go Outdated Show resolved Hide resolved
stringify/stringify.go Outdated Show resolved Hide resolved
uuid/uuid_test.go Outdated Show resolved Hide resolved
uuid/uuid_test.go Outdated Show resolved Hide resolved
@lvrach lvrach enabled auto-merge (squash) April 8, 2024 16:06
@fracasula fracasula disabled auto-merge April 8, 2024 16:47
@fracasula
Copy link
Collaborator

@lvrach I disabled auto-merge in this instance to give @achettyiitr a chance to address the optional comments as he sees fit.

@achettyiitr achettyiitr mentioned this pull request Apr 8, 2024
Merged
1 task
lvrach
lvrach reviewed Apr 8, 2024
View reviewed changes
ip/ip.go Outdated Show resolved Hide resolved
@achettyiitr achettyiitr merged commit 877fd55 into main Apr 9, 2024
10 checks passed
@achettyiitr achettyiitr deleted the feat.additional-helpers branch April 9, 2024 07:09
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sidddddarth Sidddddarth Sidddddarth approved these changes

@fracasula fracasula fracasula approved these changes

@lvrach lvrach lvrach approved these changes

@cisse21 cisse21 Awaiting requested review from cisse21

@mihir20 mihir20 Awaiting requested review from mihir20

@BonapartePC BonapartePC Awaiting requested review from BonapartePC

Assignees
No one assigned
Labels
config with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achettyiitr @fracasula @lvrach @Sidddddarth