chore: expose otel version from stats library #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
approved these changes
May 29, 2024
achettyiitr
approved these changes
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposes otel version so downstream dependencies won't need to import open tel package for testing.
For example here https://github.com/rudderlabs/rudder-server/blob/f4b5d114508db4795e71a13eeb9596c7ebd1838b/integration_test/tracing/tracing_test.go#L692z
rudder-server depending on
go.opentelemetry.io/otelcauses issues when upgrading dependencies.By using exposing otelVersion from stats, we remove this minor unnecessary dependency.
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1123/address-vulnerability-issues
Security