chore: improve scylla container health check #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cisse21
force-pushed
the
chore.addTestScylla
branch
from
a1e3f3b
to
e6c7af3
Compare
cisse21
changed the title
lvrach
reviewed
Aug 1, 2024
| @@ -2,6 +2,8 @@ module github.com/rudderlabs/rudder-go-kit | |||
|
|
|||
| go 1.22.5 | |||
|
|
|||
| replace github.com/gocql/gocql => github.com/scylladb/gocql v1.14.2 | |||
There was a problem hiding this comment.
I thought this was a good practice to pin the version as we are doing the same in rudder-server for the replace block
There was a problem hiding this comment.
Also have this error replacement module without version must be directory path (rooted or starting with . or ..) if I remove the version
There was a problem hiding this comment.
I get it:
module declares its path as: github.com/gocql/gocql
but was required as: github.com/scylladb/gocqlSo we can't do much. The sensible way is to replace with latest but then a go mod tidy would replace latest with the version. And that's what you got now so it's cool.
replace github.com/gocql/gocql => github.com/scylladb/gocql latestThere was a problem hiding this comment.
Basically they forked without changing the path:
https://github.com/scylladb/gocql/blob/master/go.mod
module github.com/gocql/gocql
require (
github.com/bitly/go-hostpool v0.0.0-20171023180738-a3a6125de932 // indirect
github.com/bmizerany/assert v0.0.0-20160611221934-b7ed37b82869 // indirect
github.com/golang/snappy v0.0.3
github.com/google/go-cmp v0.4.0
github.com/hailocab/go-hostpool v0.0.0-20160125115350-e80d13ce29ed
github.com/kr/pretty v0.1.0 // indirect
github.com/stretchr/testify v1.3.0 // indirect
golang.org/x/net v0.0.0-20220526153639-5463443f8c37
gopkg.in/inf.v0 v0.9.1
sigs.k8s.io/yaml v1.3.0
)
retract (
v1.8.0 // tag from kiwicom/gocql added by mistake to scylladb/gocql
v1.8.1 // tag from kiwicom/gocql added by mistake to scylladb/gocql
v1.9.0 // tag from kiwicom/gocql added by mistake to scylladb/gocql
v1.10.0 // tag from kiwicom/gocql added by mistake to scylladb/gocql
)
go 1.13
lvrach
approved these changes
Aug 1, 2024
fracasula
approved these changes
Aug 1, 2024
cisse21
force-pushed
the
chore.addTestScylla
branch
from
e6c7af3
to
7a2f05d
Compare
cisse21
force-pushed
the
chore.addTestScylla
branch
from
7a2f05d
to
fd6d970
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
Fixes PIPE-1374
Security