Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid starting a limiter using a limit less than zero #64

Merged
merged 1 commit into from
May 31, 2023

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented May 31, 2023

Description

To avoid being stuck forever

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13 ⚠️

Comparison is base (3c6013a) 78.00% compared to head (69f3ef5) 77.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   78.00%   77.88%   -0.13%     
==========================================
  Files          56       56              
  Lines        3555     3558       +3     
==========================================
- Hits         2773     2771       -2     
- Misses        646      650       +4     
- Partials      136      137       +1     
Impacted Files Coverage Δ
sync/limiter.go 91.89% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum merged commit 6b9295d into main May 31, 2023
@atzoum atzoum deleted the fix.limiterLimit branch May 31, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants