feat: introduce db stats collector #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
force-pushed
the
feat.dbstats
branch
from
393b4f1
to
4895d62
Compare
fracasula
approved these changes
Sep 24, 2024
Sidddddarth
reviewed
Sep 24, 2024
lvrach
force-pushed
the
feat.dbstats
branch
from
c02a901
to
2ee3456
Compare
achettyiitr
reviewed
Sep 25, 2024
achettyiitr
approved these changes
Sep 26, 2024
lvrach
force-pushed
the
feat.dbstats
branch
from
0b2a3b3
to
9ce2212
Compare
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
database/sqlpackage exposes stats that are important for observing the state of the system, help us to address issue and guide to further optimisations.Changes
This PR is:
database/sql.DBCollectors are ment to be used to periodically sampled values.
The stats implementation is responsible for running them and may optimise the collection to better match its own push/pull behaviour.
Linear Ticket
https://linear.app/rudderstack/issue/PRI-48/database-sql-stats
Security