chore: otel stable metric API update v1.16.0 / v0.39.0 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
requested review from
lvrach,
atzoum,
cisse21,
BonapartePC,
achettyiitr and
Sidddddarth
fracasula
commented
Jun 30, 2023
| // WithNamespace configures the Exporter to prefix metric with the given namespace. | ||
| // Metadata metrics such as target_info and otel_scope_info are not prefixed since these | ||
| // have special behavior based on their name. | ||
| func WithNamespace(ns string) Option { |
There was a problem hiding this comment.
NOTE: I added this even though we are not using it just to avoid having our prometheus exporter drift too much from the original.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
- Coverage 78.09% 78.00% -0.09%
==========================================
Files 67 67
Lines 4816 4815 -1
==========================================
- Hits 3761 3756 -5
- Misses 856 861 +5
+ Partials 199 198 -1
☔ View full report in Codecov by Sentry. |
achettyiitr
approved these changes
Jul 3, 2023
lvrach
approved these changes
Jul 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new stable metric API has been released, thus this update. My tests highlight no regressions.
Additional changes
I'm removing a mutex optimization done a while back for gRPC which we are not using at the moment due to its instability.
My guess is that it could be related to this issue.
Notion Ticket
Security