-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(warehouse): batching of alter add statements #2484
Conversation
Codecov ReportBase: 44.09% // Head: 43.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2484 +/- ##
==========================================
- Coverage 44.09% 43.20% -0.89%
==========================================
Files 187 186 -1
Lines 39255 40041 +786
==========================================
- Hits 17308 17300 -8
- Misses 20843 21637 +794
Partials 1104 1104
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Note: I don't have a lot of context on how those different warehouse work. I rely on automation tests to verify those changes.
I made a few non-blocking comments/suggestions
Except for the Azure synapse and S3 Datalake (Glue), all destinations are covered with multiple columns for alter around Integration tests. So we are good here. |
For Azure synapse, tested the changes locally. |
Description
Batching of
ALTER ADD
statements in order to optimize the Queries that run on the warehouse.Currently, we are following running single
ALTER ADD
statement changes for new properties of the Schema. If we batch these, we don't need to run many Queries for these.Notion Ticket
https://www.notion.so/rudderstacks/Use-batching-to-run-several-of-alter-statements-81ae26d5db6f4b2ca8e0258e3ce0cba6
Security