-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: jobsDB backup query time #2521
Conversation
Codecov ReportBase: 43.93% // Head: 44.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2521 +/- ##
==========================================
+ Coverage 43.93% 44.04% +0.10%
==========================================
Files 187 187
Lines 39114 39255 +141
==========================================
+ Hits 17186 17290 +104
- Misses 20840 20862 +22
- Partials 1088 1103 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9eefc0a
to
802ebdb
Compare
Description
So, to avoid this, we are setting the default value of
LIMIT
to a large value100,000
since, we are already guarded byrunning_payload_size
, to avoid OOM kill.Notion Ticket
https://www.notion.so/rudderstacks/remove-LIMIT-on-row-count-from-getBackUpQuery-bde1f44331d444f7a33e3b3f99904470