Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup unused code #2561

Merged
merged 1 commit into from
Oct 13, 2022
Merged

chore: cleanup unused code #2561

merged 1 commit into from
Oct 13, 2022

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Oct 13, 2022

Description

Cleaning up unused code left over from deleting Migrator code

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 43.86% // Head: 43.81% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (8a691d2) compared to base (8cba05e).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
- Coverage   43.86%   43.81%   -0.06%     
==========================================
  Files         187      187              
  Lines       39090    39084       -6     
==========================================
- Hits        17146    17123      -23     
- Misses      20860    20879      +19     
+ Partials     1084     1082       -2     
Impacted Files Coverage Δ
jobsdb/readonly_jobsdb.go 34.48% <0.00%> (ø)
processor/processor.go 71.23% <ø> (-0.68%) ⬇️
jobsdb/setup.go 90.47% <33.33%> (-0.44%) ⬇️
jobsdb/jobsdb_utils.go 78.57% <100.00%> (ø)
router/router.go 66.76% <100.00%> (ø)
services/stats/stats.go 88.48% <0.00%> (-1.82%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️
config/backend-config/namespace_config.go 73.95% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 force-pushed the chore.cleanupUnusedCode branch 2 times, most recently from 142209c to da795a2 Compare October 13, 2022 06:09
@cisse21 cisse21 force-pushed the chore.cleanupUnusedCode branch from da795a2 to 8a691d2 Compare October 13, 2022 06:23
Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why are we removing enableGateway flag?

@cisse21
Copy link
Member Author

cisse21 commented Oct 13, 2022

It's by default true right , I don't think there is any case in gatewayAppHandler and embeddedAppHandler where we use enableGateway as false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants