-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup unused code #2561
Conversation
Codecov ReportBase: 43.86% // Head: 43.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
- Coverage 43.86% 43.81% -0.06%
==========================================
Files 187 187
Lines 39090 39084 -6
==========================================
- Hits 17146 17123 -23
- Misses 20860 20879 +19
+ Partials 1084 1082 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
142209c
to
da795a2
Compare
da795a2
to
8a691d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but why are we removing enableGateway flag?
It's by default true right , I don't think there is any case in gatewayAppHandler and embeddedAppHandler where we use enableGateway as false |
Description
Cleaning up unused code left over from deleting Migrator code
Notion Ticket
Notion Link
Security