Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(warehouse): warehouse formatting changes #2568

Merged
merged 14 commits into from
Oct 21, 2022

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 14, 2022

Description

  • Typo: In a word
  • Empty slice declaration using a literal.
  • Error string should not be capitalized or end with a punctuation mark
  • Grouping of variable/constants
  • Comments format
  • Readable functions and parameter names.
  • Exported function with the unexported return type

Notion Ticket

https://www.notion.so/rudderstacks/Warehouse-style-lints-73a7079e30f34625a738e2dd2c98092c

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr changed the title chore(warehouse): warehouse style lints chore(warehouse): warehouse lints Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 44.00% // Head: 43.98% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bb8f73a) compared to base (09dba21).
Patch coverage: 19.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
- Coverage   44.00%   43.98%   -0.02%     
==========================================
  Files         187      187              
  Lines       39086    39114      +28     
==========================================
+ Hits        17198    17204       +6     
- Misses      20807    20829      +22     
  Partials     1081     1081              
Impacted Files Coverage Δ
warehouse/bigquery/bigquery.go 0.00% <0.00%> (ø)
warehouse/clickhouse/clickhouse.go 0.00% <0.00%> (ø)
warehouse/deltalake/query_builder.go 0.00% <ø> (ø)
warehouse/identities.go 1.04% <0.00%> (-0.01%) ⬇️
warehouse/jobs/handlers.go 0.00% <0.00%> (ø)
warehouse/jobs/runner.go 0.00% <0.00%> (ø)
warehouse/jobs/utils.go 8.33% <0.00%> (+0.26%) ⬆️
warehouse/mssql/mssql.go 0.00% <0.00%> (ø)
warehouse/postgres/postgres.go 0.00% <0.00%> (ø)
warehouse/redshift/redshift.go 0.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achettyiitr achettyiitr requested review from abhimanyubabbar, lvrach and Jayachand and removed request for abhimanyubabbar October 14, 2022 05:21
@achettyiitr achettyiitr changed the title chore(warehouse): warehouse lints chore(warehouse): warehouse formatting changes. Oct 14, 2022
@achettyiitr achettyiitr changed the title chore(warehouse): warehouse formatting changes. chore(warehouse): warehouse formatting changes Oct 14, 2022
@achettyiitr achettyiitr self-assigned this Oct 14, 2022
@achettyiitr achettyiitr merged commit 888f6f8 into master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants