Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warehouse): parquet oom and ftr changes #2599

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

Jayachand
Copy link
Contributor

@Jayachand Jayachand commented Oct 20, 2022

Description

parquet OOM fix: max limit on columns loading into parquet file
FTR fall back mechanism changes

Notion Ticket

https://www.notion.so/rudderstacks/Warehouse-release-1-2-x-fixes-efedcf51c6d14428acb8bc07d0ff9ec1

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 43.85% // Head: 43.87% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f850960) compared to base (9ea25aa).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.2.x    #2599      +/-   ##
=================================================
+ Coverage          43.85%   43.87%   +0.01%     
=================================================
  Files                187      187              
  Lines              39111    39116       +5     
=================================================
+ Hits               17154    17162       +8     
+ Misses             20873    20869       -4     
- Partials            1084     1085       +1     
Impacted Files Coverage Δ
warehouse/slave.go 1.08% <0.00%> (-0.01%) ⬇️
warehouse/utils/utils.go 70.18% <20.00%> (+0.05%) ⬆️
warehouse/upload.go 18.60% <100.00%> (+0.04%) ⬆️
utils/httputil/server.go 80.76% <0.00%> (-11.54%) ⬇️
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
warehouse/schema.go 48.98% <0.00%> (+1.15%) ⬆️
enterprise/reporting/reporting.go 9.77% <0.00%> (+1.43%) ⬆️
enterprise/reporting/setup.go 52.38% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

warehouse/slave.go Outdated Show resolved Hide resolved
Copy link
Contributor

@abhimanyubabbar abhimanyubabbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants