fix: set page size irrespective of suppressAPIToken #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
approved these changes
Oct 25, 2022
lvrach
approved these changes
Oct 25, 2022
atzoum
approved these changes
Oct 25, 2022
Codecov ReportBase: 44.08% // Head: 44.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
- Coverage 44.08% 44.03% -0.05%
==========================================
Files 187 188 +1
Lines 39147 39266 +119
==========================================
+ Hits 17256 17291 +35
- Misses 20808 20871 +63
- Partials 1083 1104 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cisse21
approved these changes
Oct 25, 2022
Closed
saurav-malani
changed the title
This was referenced Nov 7, 2022
Merged
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
pageSizeis only set ifsuppressAPITokenis set, which is set only after we get response for 1st request fromgw. So, the the 1st request url from gw doesn't havepageSizeset. And, since the go routine sleep for 5 min if the number of suppression user received is less thanpageSize. Because of this bug, there was an unnecessary delay in suppression sync atgwend.This issue is fixed in this PR.
Notion Ticket
https://www.notion.so/rudderstacks/GW-suppression-pageSize-bug-fix-71f965130db842d188ae265263f72fa1