Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(warehouse): verify workspace ID in stats #2615

Merged
merged 7 commits into from
Oct 26, 2022

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Oct 25, 2022

Description

workspace ID needs to be populated in warehouse stats. Also, it should be populated in wh_staging_files and wh_uploads as well.

Notion Ticket

https://www.notion.so/rudderstacks/Stats-testing-for-workspace-using-prometheus-926ef3734a214785827cac25f59706ac

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 44.06% // Head: 44.02% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0d79c05) compared to base (71d8c99).
Patch coverage: 67.46% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2615      +/-   ##
==========================================
- Coverage   44.06%   44.02%   -0.04%     
==========================================
  Files         188      188              
  Lines       39266    39269       +3     
==========================================
- Hits        17301    17288      -13     
- Misses      20861    20876      +15     
- Partials     1104     1105       +1     
Impacted Files Coverage Δ
warehouse/deltalake/deltalake.go 0.00% <0.00%> (ø)
warehouse/postgres/postgres.go 0.00% <0.00%> (ø)
warehouse/utils/utils.go 70.18% <0.00%> (ø)
warehouse/warehouse.go 8.83% <0.00%> (-0.02%) ⬇️
warehouse/stats.go 64.76% <71.42%> (ø)
warehouse/archiver.go 65.32% <100.00%> (ø)
services/stats/stats.go 88.48% <0.00%> (-1.82%) ⬇️
services/rsources/handler.go 69.72% <0.00%> (-1.39%) ⬇️
processor/processor.go 71.23% <0.00%> (-0.83%) ⬇️
enterprise/reporting/reporting.go 9.77% <0.00%> (+1.43%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This was referenced Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants