fix(batchrouter): concurrent modification of job parameters causes panic #2631
Conversation
atzoum
requested review from
lvrach,
fracasula,
saurav-malani,
Sidddddarth,
chandumlg and
cisse21
| wg.Add(1) | ||
| brt.processQ <- &BatchDestinationDataT{batchDestination: *batchDest, jobs: destJobs, parentWG: &wg} | ||
| } else { | ||
| brt.logger.Errorf("BRT: %s: Destination %s not found in destinationsMap", brt.destType, destID) |
There was a problem hiding this comment.
Although not relevant to this pr, we should do something about jobs of destination not found in destinationsMap. Abort?
There was a problem hiding this comment.
This can happen also as a side-effect of not being able to unmarshall parameters. Apart from that, yes I agree we should have some (safe) strategy for handling jobs of deleted destinations both in router & batch router.
Codecov ReportBase: 44.09% // Head: 44.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
- Coverage 44.09% 44.02% -0.07%
==========================================
Files 187 187
Lines 39255 39234 -21
==========================================
- Hits 17308 17274 -34
- Misses 20843 20851 +8
- Partials 1104 1109 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
Notion Ticket
Link
Security