Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove leftover flag.Parse() #2643

Merged
merged 1 commit into from
Nov 3, 2022
Merged

chore: remove leftover flag.Parse() #2643

merged 1 commit into from
Nov 3, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 3, 2022

Description

Fixing a regression introduced by #2379

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum marked this pull request as ready for review November 3, 2022 07:33
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 43.87% // Head: 43.82% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (e8f5257) compared to base (cb230b0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2643      +/-   ##
==========================================
- Coverage   43.87%   43.82%   -0.05%     
==========================================
  Files         187      187              
  Lines       40024    40038      +14     
==========================================
- Hits        17560    17547      -13     
- Misses      21368    21393      +25     
- Partials     1096     1098       +2     
Impacted Files Coverage Δ
router/router.go 74.20% <0.00%> (-0.62%) ⬇️
router/transformer/transformer.go 66.66% <ø> (ø)
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️
services/rsources/handler.go 69.72% <0.00%> (-1.39%) ⬇️
services/stats/stats.go 90.30% <0.00%> (+1.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants