Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unused variables #2647

Merged
merged 4 commits into from
Nov 3, 2022
Merged

chore: clean up unused variables #2647

merged 4 commits into from
Nov 3, 2022

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Nov 3, 2022

Description

Cleaning up few unused variables and functions across rudder-server

Notion Ticket

Notion Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21
Copy link
Member Author

cisse21 commented Nov 3, 2022

Removed failedEventsList from status object because we have another query from rudder-cli which displays the status of the last 5 failed jobs get-failed

@cisse21 cisse21 force-pushed the chore.routerCleanUp branch 2 times, most recently from f030706 to ce4ab2d Compare November 3, 2022 10:26
@cisse21 cisse21 force-pushed the chore.routerCleanUp branch from ce4ab2d to 6802059 Compare November 3, 2022 10:43
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 43.90% // Head: 43.85% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (6802059) compared to base (3659e12).
Patch coverage: 35.29% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
- Coverage   43.90%   43.85%   -0.06%     
==========================================
  Files         187      187              
  Lines       40038    39944      -94     
==========================================
- Hits        17579    17516      -63     
+ Misses      21363    21332      -31     
  Partials     1096     1096              
Impacted Files Coverage Δ
processor/processor.go 72.02% <ø> (-0.16%) ⬇️
router/admin.go 4.23% <0.00%> (+0.20%) ⬆️
router/failed-events-manager.go 3.44% <ø> (ø)
utils/misc/misc.go 12.85% <ø> (+0.31%) ⬆️
processor/transformer/transformer.go 64.97% <33.33%> (-0.79%) ⬇️
router/router.go 74.00% <36.66%> (-0.21%) ⬇️
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 marked this pull request as ready for review November 3, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants