Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use WriteTimeout instead of Gateway.pendingEventsQueryTimeout #2649

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 3, 2022

Description

Keeping it simple

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum marked this pull request as ready for review November 3, 2022 14:16
@atzoum atzoum requested review from chandumlg and cisse21 November 3, 2022 14:16
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 43.90% // Head: 43.85% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a80958f) compared to base (3659e12).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2649      +/-   ##
==========================================
- Coverage   43.90%   43.85%   -0.05%     
==========================================
  Files         187      187              
  Lines       40038    40088      +50     
==========================================
+ Hits        17579    17582       +3     
- Misses      21363    21411      +48     
+ Partials     1096     1095       -1     
Impacted Files Coverage Δ
gateway/gateway.go 55.76% <0.00%> (ø)
warehouse/azure-synapse/azure-synapse.go 0.00% <0.00%> (ø)
warehouse/bigquery/bigquery.go 0.00% <0.00%> (ø)
warehouse/clickhouse/clickhouse.go 0.00% <0.00%> (ø)
warehouse/deltalake/deltalake.go 0.00% <0.00%> (ø)
warehouse/identities.go 1.04% <0.00%> (ø)
warehouse/mssql/mssql.go 0.00% <0.00%> (ø)
warehouse/postgres/postgres.go 0.00% <0.00%> (ø)
warehouse/redshift/redshift.go 0.00% <0.00%> (ø)
warehouse/schema.go 47.82% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants