chore: fix replay bugs #2653
Merged
chore: fix replay bugs #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 43.74% // Head: 43.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2653 +/- ##
==========================================
- Coverage 43.74% 43.69% -0.06%
==========================================
Files 187 191 +4
Lines 39993 40483 +490
==========================================
+ Hits 17494 17688 +194
- Misses 21403 21690 +287
- Partials 1096 1105 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…erver into chore.replayBugFixes
BonapartePC
approved these changes
Nov 7, 2022
saurav-malani
approved these changes
Nov 7, 2022
Closed
fracasula
reviewed
Nov 7, 2022
| @@ -23,7 +23,7 @@ func loadConfig() { | |||
| } | |||
|
|
|||
| func initFileManager() (filemanager.FileManager, string, error) { | |||
| bucket := strings.TrimSpace(config.GetString("JOBS_BACKUP_BUCKET", "")) | |||
| bucket := strings.TrimSpace(config.GetString("JOBS_REPLAY_BACKUP_BUCKET", "")) | |||
There was a problem hiding this comment.
@cisse21 Is it OK to just change this configuration setting? Doesn't it have to be backward compatible or something?
There was a problem hiding this comment.
Replay is done on demand. These envs are not served anywhere. So, it is okay for now.
This was referenced Nov 7, 2022
Merged
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing replay bugs that occurred while replaying for recroom
Notion Ticket
Notion Link
Security