fix: use proper status code to handle warehouse process #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 43.73% // Head: 45.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
==========================================
+ Coverage 43.73% 45.41% +1.67%
==========================================
Files 191 287 +96
Lines 40483 47789 +7306
==========================================
+ Hits 17707 21702 +3995
- Misses 21671 24709 +3038
- Partials 1105 1378 +273
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lvrach
reviewed
Nov 7, 2022
lvrach
reviewed
Nov 7, 2022
lvrach
reviewed
Nov 7, 2022
achettyiitr
force-pushed
the
fix.warehouse-process-api
branch
from
474b369 to
dff1133
Compare
atzoum
reviewed
Nov 7, 2022
|
|
||
| if resp.StatusCode == http.StatusOK { | ||
| _, err = io.Copy(io.Discard, resp.Body) |
There was a problem hiding this comment.
achettyiitr
force-pushed
the
fix.warehouse-process-api
branch
from
74b9804 to
a8c40e7
Compare
….warehouse-process-api
achettyiitr
force-pushed
the
fix.warehouse-process-api
branch
from
a8c40e7 to
3ff3c98
Compare
lvrach
approved these changes
Nov 7, 2022
cisse21
approved these changes
Nov 7, 2022
This was referenced Nov 7, 2022
Closed
Merged
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle status code when batch router hits warehouse
v1/processURL.Notion Ticket
https://www.notion.so/rudderstacks/Handle-warehouse-process-9fa6aa8da88948999ea81bf5a34a352a
Security