Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github action for prerelease workflow #2660

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 7, 2022

Description

To support a prerelease (release candidate) workflow

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

release-type: go
package-name: rudder-server
default-branch: ${{ steps.extract_branch.outputs.branch }}
changelog-types: '[{"type":"feat","section":"Features","hidden":false},{"type":"fix","section":"Bug Fixes","hidden":false},{"type":"chore","section":"Miscellaneous","hidden":false},{"type":"refactor","section":"Miscellaneous","hidden":false},{"type":"test","section":"Miscellaneous","hidden":false},{"type":"doc","section":"Documentation","hidden":false}]'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to split this in multiple lines? 🤔

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 43.73% // Head: 43.74% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8b459e2) compared to base (8ac05c2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2660   +/-   ##
=======================================
  Coverage   43.73%   43.74%           
=======================================
  Files         191      191           
  Lines       40483    40483           
=======================================
+ Hits        17707    17708    +1     
+ Misses      21672    21669    -3     
- Partials     1104     1106    +2     
Impacted Files Coverage Δ
services/rsources/handler.go 69.72% <0.00%> (-0.84%) ⬇️
processor/processor.go 72.09% <0.00%> (+0.05%) ⬆️
config/backend-config/namespace_config.go 73.95% <0.00%> (+3.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum requested review from chandumlg and pChondros November 7, 2022 12:46
{
"type": "chore",
"section":"Miscellaneous",
"hidden": false},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] Is there a typo here with the extra closing bracket?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM just different indentation.

{
"type": "chore",
"section":"Miscellaneous",
"hidden": false},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM just different indentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants