-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(destination): empty oauth account check #2675
Conversation
…sing proxy response
Codecov ReportBase: 45.43% // Head: 45.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/1.3.x #2675 +/- ##
=================================================
+ Coverage 45.43% 45.45% +0.02%
=================================================
Files 287 287
Lines 47777 47779 +2
=================================================
+ Hits 21707 21720 +13
+ Misses 24691 24683 -8
+ Partials 1379 1376 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Description
The oauth account id can be empty. Due to the changes we might do as part of the regulation-worker support for Universal Analytics.
This check serves as protection when
rudderAccountId
is missing.Background:
As part of the changes for supporting OAuth in regulation-worker module. We need to have one more field in destination config known as
rudderUserDeleteAccountId
which indicates that this account information will be used for sending delete user request to destinationThis user delete feature can sometimes only require OAuth and event-delivery for the same destination might not need OAuth, int this case, we don’t populate
rudderAccountId
but we populaterudderUserDeleteAccountId
with the access token information(which will be used for user-deletion requests)This can cause a problem while processing the transformer proxy response for OAuth destinations. We would need to add a check to prevent any errors for such things.
Notion Ticket
https://www.notion.so/rudderstacks/Integrate-OAuth-in-regulation-worker-module-of-server-dae0cf6ef89e41eb91e9212ac524cf49
Security