fix: reset job status ids during internal migration #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
requested review from
Sidddddarth,
chandumlg,
cisse21 and
saurav-malani
Codecov ReportBase: 0.00% // Head: 45.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## release/1.3.x #2684 +/- ##
==================================================
+ Coverage 0 45.42% +45.42%
==================================================
Files 0 287 +287
Lines 0 47822 +47822
==================================================
+ Hits 0 21723 +21723
- Misses 0 24721 +24721
- Partials 0 1378 +1378
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atzoum
force-pushed
the
fix.migration
branch
from
56d1584 to
bf0e617
Compare
chandumlg
approved these changes
Nov 10, 2022
cisse21
approved these changes
Nov 10, 2022
Sidddddarth
approved these changes
Nov 10, 2022
This was referenced Nov 10, 2022
Merged
atzoum
added a commit
that referenced
this pull request
Nov 10, 2022
atzoum
added a commit
that referenced
this pull request
Nov 11, 2022
This was referenced Nov 11, 2022
Closed
Closed
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression introduced by #2559 where the id column of job statuses was not reset during an internal migration, causing subsequent job statuses inserted to the status table to not be considered as the latest ones, since migrated statuses were already stored with higher ids and the latest job status is retrieved based on the id column.
Security