Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add json-data type support in redis #4633

Merged
merged 27 commits into from
May 21, 2024
Merged

feat: add json-data type support in redis #4633

merged 27 commits into from
May 21, 2024

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented May 2, 2024 •
edited by achettyiitr
Loading

Description

Through this PR, we are planning to support JSON data-type in Redis

Linear Ticket

Resolves INT-2095

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 2, 2024 •
edited
Loading

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sanpj2292 sanpj2292 self-assigned this May 2, 2024
@codecov Codecov
Copy link

codecov bot commented May 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.66102% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 74.48%. Comparing base (6a90d73) to head (caedaf2).

Files Patch % Lines
services/kvstoremanager/redis.go 77.35% 8 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4633      +/-   ##
==========================================
+ Coverage   74.45%   74.48%   +0.03%     
==========================================
  Files         413      413              
  Lines       48706    48752      +46     
==========================================
+ Hits        36262    36314      +52     
+ Misses      10060    10054       -6     
  Partials     2384     2384

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanpj2292 sanpj2292 marked this pull request as ready for review May 14, 2024 08:36
achettyiitr
achettyiitr reviewed May 14, 2024
View reviewed changes
services/kvstoremanager/redis.go Outdated Show resolved Hide resolved
services/kvstoremanager/redis.go Outdated Show resolved Hide resolved
services/kvstoremanager/redis.go Outdated Show resolved Hide resolved
services/kvstoremanager/redis.go Outdated Show resolved Hide resolved
services/kvstoremanager/redis.go Outdated Show resolved Hide resolved
router/customdestinationmanager/customdestinationmanager_test.go Outdated Show resolved Hide resolved
router/customdestinationmanager/customdestinationmanager_test.go Outdated Show resolved Hide resolved
router/customdestinationmanager/customdestinationmanager_test.go Outdated Show resolved Hide resolved
router/customdestinationmanager/customdestinationmanager_test.go Outdated Show resolved Hide resolved
router/customdestinationmanager/customdestinationmanager_test.go Outdated Show resolved Hide resolved
achettyiitr
achettyiitr reviewed May 20, 2024
View reviewed changes
utils/tests/redis.go Outdated Show resolved Hide resolved
fracasula

This comment was marked as outdated.

Sign in to view

fracasula
fracasula approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment. It should be fairly easy to do if you agree.

services/kvstoremanager/redis.go Outdated Show resolved Hide resolved
chore: rename Connect to CreateClient
4e1e67e 
- chore: update mock using mock generator
koladilip
koladilip approved these changes May 21, 2024
View reviewed changes
services/kvstoremanager/redis.go Show resolved Hide resolved
koladilip
koladilip approved these changes May 21, 2024
View reviewed changes
services/kvstoremanager/redis.go
}
args := []string{key, actualPath, jsonVal.String()}

if actualPath != "$" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some comments here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added them. Can you check and let me know if they are ok ?

@sanpj2292 sanpj2292 merged commit 73f7275 into master May 21, 2024
52 checks passed
@sanpj2292 sanpj2292 deleted the feat.redis-json branch May 21, 2024 12:16
This was referenced May 22, 2024
Merged
Merged
Merged
Merged
This was referenced May 30, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achettyiitr achettyiitr achettyiitr approved these changes

@koladilip koladilip koladilip approved these changes

@fracasula fracasula fracasula approved these changes

@yashasvibajpai yashasvibajpai Awaiting requested review from yashasvibajpai

Assignees

@sanpj2292 sanpj2292

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanpj2292 @fracasula @koladilip @achettyiitr