Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use jsoniter in warehouse slave #4693

Merged
merged 3 commits into from
May 21, 2024
Merged

chore: use jsoniter in warehouse slave #4693

merged 3 commits into from
May 21, 2024

Conversation

mihir20
Copy link
Contributor

@mihir20 mihir20 commented May 21, 2024

Description

warehouse-slave is spending a lot of cpu time in marshalling JSON, but we don't use jsoniter to marshall or unmarshall.

image

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1104/warehouse-slave-is-spending-a-lot-of-cpu-time-in-marshaling-json-but

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

coderabbitai bot commented May 21, 2024

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mihir20 mihir20 marked this pull request as ready for review May 21, 2024 10:04
@@ -33,6 +34,7 @@ import (
var (
errIncompatibleSchemaConversion = errors.New("incompatible schema conversion")
errSchemaConversionNotSupported = errors.New("schema conversion not supported")
json = jsoniter.ConfigCompatibleWithStandardLibrary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can even explore jsoniter.ConfigFastet as well. https://github.com/json-iterator/go/wiki/Config#built-in-configuration

Suggested change
json = jsoniter.ConfigCompatibleWithStandardLibrary
json = jsoniter.ConfigFastest

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.55%. Comparing base (91958c5) to head (f057d63).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4693      +/-   ##
==========================================
+ Coverage   74.46%   74.55%   +0.08%     
==========================================
  Files         413      413              
  Lines       48706    48706              
==========================================
+ Hits        36269    36311      +42     
+ Misses      10056    10017      -39     
+ Partials     2381     2378       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mihir20 mihir20 merged commit 6a90d73 into master May 21, 2024
52 checks passed
@mihir20 mihir20 deleted the mihir/pipe-1104 branch May 21, 2024 11:29
This was referenced May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants