-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: store anonymous ids in userID hll to optimise storage #4988
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
e14e42b
to
52b3fdb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4988 +/- ##
==========================================
+ Coverage 74.37% 74.41% +0.04%
==========================================
Files 428 428
Lines 49909 49915 +6
==========================================
+ Hits 37119 37146 +27
+ Misses 10340 10328 -12
+ Partials 2450 2441 -9 ☔ View full report in Codecov by Sentry. |
} | ||
|
||
if userID != "" && anonymousID != "" { | ||
if userID != "" && anonymousID != "" && userID != anonymousID { | ||
combinedUserIDAnonymousID := combineUserIDAnonymousID(userID, anonymousID) | ||
workspaceSourceUserIdTypeMap[job.WorkspaceId][sourceID] = u.recordIdentifier(workspaceSourceUserIdTypeMap[job.WorkspaceId][sourceID], combinedUserIDAnonymousID, idTypeIdentifiedAnonymousID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably rename these columns to trackedIdentifiers
and mergedIdentifiers
at a later stage
I think we can have one realistic case in the integration tests. Like we generate few 100s - 1000s of events with |
We actually are generating events close to 100 in our integration test |
Description
store anonymous ids in userID hll to optimise storage and memory
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1384/add-anonymous-ids-in-userid-column
Security