-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: include transformationId in transformer client metrics #5055
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a32914c
to
c0d643b
Compare
tr.logger = logger.NOP | ||
tr.conf = config.Default | ||
tr.client = srv.Client() | ||
tr.guardConcurrency = make(chan struct{}, 200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[question] do we have tests with way less concurrency as well to see if something gets stuck?
c0d643b
to
24be280
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5055 +/- ##
==========================================
+ Coverage 74.71% 74.75% +0.03%
==========================================
Files 436 436
Lines 50477 50484 +7
==========================================
+ Hits 37714 37738 +24
+ Misses 10280 10270 -10
+ Partials 2483 2476 -7 ☔ View full report in Codecov by Sentry. |
Description
Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1486/include-transformationid-in-transformer-cli-observability
Resolves PIPE-1486
Security