Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: each router handle stores the entire connections map #5109

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

Sidddddarth
Copy link
Member

Description

Each router handle stored the connections for all destinations, even those of which were not of the same destType!
It's now filtered so router handles only store connection details of destinations of the same destType.

Linear Ticket

Resolves PIPE-1540

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth changed the title chore: make scylla hosts as slice (#5107) fix: each router handle stores the entire connections map (#5107) Sep 18, 2024
@Sidddddarth Sidddddarth changed the title fix: each router handle stores the entire connections map (#5107) fix: each router handle stores the entire connections map Sep 18, 2024
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sidddddarth Sidddddarth enabled auto-merge (squash) September 18, 2024 07:08
@Sidddddarth Sidddddarth merged commit dfbfa78 into release/1.34.x Sep 18, 2024
53 checks passed
@Sidddddarth Sidddddarth deleted the fix.filterRouterConnectionsMap branch September 18, 2024 08:28
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.77%. Comparing base (0ada31f) to head (50f1ce7).
Report is 1 commits behind head on release/1.34.x.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.34.x    #5109      +/-   ##
==================================================
- Coverage           74.80%   74.77%   -0.03%     
==================================================
  Files                 435      435              
  Lines               50436    50438       +2     
==================================================
- Hits                37728    37716      -12     
+ Misses              10241    10237       -4     
- Partials             2467     2485      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants