Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use with instead of assert as per latest node version #95

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

akashrpo
Copy link

Thank You for Contributing to RudderTyper!

We sincerely appreciate the time and effort you invest in helping to improve RudderTyper. To make the most of your contribution, we kindly ask that you document your Pull Request thoroughly.

Please note that if the information provided is insufficient, or if the Pull Request does not align with our roadmap, we may need to respectfully thank you for your effort and close the issue.

Description 📝

use with instead of assert as per latest node version
That is because assert support nodejs/node#52104 in favour of with that is based on a more recent version of Import Attributes proposal.

Respect Earns Respect 👏

We ask that you adhere to our Code of Conduct. In summary:

  • Use welcoming and inclusive language.
  • Respect differing viewpoints and experiences.
  • Accept constructive criticism gracefully.
  • Focus on what is best for the community.
  • Show empathy toward other community members.

@akashrpo akashrpo merged commit babc2b7 into develop Dec 13, 2024
4 checks passed
@akashrpo akashrpo deleted the fix/replace-assert-with branch December 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants