chore(redshift): retry schema does not exist errors in list schemas #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 87.00% 87.04% +0.03%
==========================================
Files 87 88 +1
Lines 3872 3882 +10
==========================================
+ Hits 3369 3379 +10
Misses 347 347
Partials 156 156 ☔ View full report in Codecov by Sentry. |
atzoum
force-pushed
the
fix.flakyTest
branch
4 times, most recently
from
6da1c4d
to
42586f1
Compare
atzoum
changed the title
|
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
Merged
atzoum
pushed a commit
that referenced
this pull request
Nov 1, 2024
🤖 I have created a release *beep* *boop* --- ## [1.13.0](v1.12.0...v1.13.0) (2024-11-01) ### Features * **redshift:** bump github.com/aws/aws-sdk-go-v2/service/redshiftdata from 1.29.4 to 1.30.1 ([#216](#216)) ([efefea6](efefea6)) * **trino:** bump github.com/trinodb/trino-go-client from 0.316.0 to 0.317.0 ([#214](#214)) ([f11118d](f11118d)) ### Miscellaneous * **deps:** bump cloud.google.com/go from 0.115.1 to 0.116.0 ([#222](#222)) ([c5c3025](c5c3025)) * **deps:** bump github.com/aws/aws-sdk-go-v2/config from 1.27.40 to 1.27.41 ([#211](#211)) ([1a35100](1a35100)) * **deps:** bump github.com/aws/aws-sdk-go-v2/config from 1.27.41 to 1.28.1 ([#227](#227)) ([9f34b6f](9f34b6f)) * **deps:** bump github.com/rudderlabs/rudder-go-kit from 0.42.0 to 0.43.0 ([#213](#213)) ([1bfe41d](1bfe41d)) * **deps:** bump google.golang.org/api from 0.199.0 to 0.204.0 ([#226](#226)) ([c7e8b62](c7e8b62)) * **deps:** bump rudderlabs/pr-description-enforcer from 1.0.0 to 1.1.0 ([#209](#209)) ([4349e7f](4349e7f)) * **redshift:** retry schema does not exist errors in list schemas ([#208](#208)) ([78a6d0a](78a6d0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the list schemas query is executed while a schema is being deleted, the query can fail with a schema does not exist error. This is happening for instance while multiple pull request tests are running. Therefore, we are now retrying such errors.
Security