Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues on https://new.weedtowonder.org/introduction.html #10173

Open
danielhjacobs opened this issue Mar 17, 2023 · 8 comments
Open

Issues on https://new.weedtowonder.org/introduction.html #10173

danielhjacobs opened this issue Mar 17, 2023 · 8 comments
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working flex Issues relating to Adobe Flex text Issues relating to text rendering/input tlf Issues relating to TLF text rendering or the TLF APIs in AVM2 unimplemented Issues for functionality that hasn't been implemented yet

Comments

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Mar 17, 2023

Describe the bug

Last edited February 1, 2024:

  1. Text does not appear properly, and some is missing, though this issue was significantly improved by avm2: Basic TLF support #13226
    Screenshot from 2023-11-15 16-10-58

  2. Clicking TLF text can sometimes make it disappear:

Screencast.from.2023-11-17.10-01-49.webm

Expected behavior

  1. Text should appear properly:
    Screenshot from 2023-03-17 11-24-01
  2. Clicking any TLF text location should not make it disappear, though it may show a cursor.
Screencast.from.2023-11-17.09-57-22.webm

Affected platform

Browser's extension

Operating system

Fedora Linux 38

Browser

Mozilla Firefox 119

Additional information

This is an AVM2 Flex animation. See also #8006 and #10175.

@danielhjacobs danielhjacobs added the bug Something isn't working label Mar 17, 2023
@n0samu n0samu added A-avm2 Area: AVM2 (ActionScript 3) flex Issues relating to Adobe Flex xml labels Mar 17, 2023
@danielhjacobs danielhjacobs changed the title Errors on http://new.weedtowonder.org/introduction.html Issues on http://new.weedtowonder.org/introduction.html Mar 17, 2023
@Lord-McSweeney Lord-McSweeney added the unimplemented Issues for functionality that hasn't been implemented yet label Mar 17, 2023
@evilpie
Copy link
Collaborator

evilpie commented Mar 17, 2023

With #10178 for XML.settings, I get:

ReferenceError: Error #1069: Property flash.text.engine::ContentElement not found on global and there is no default value.

@danielhjacobs
Copy link
Contributor Author

@n0samu n0samu added the text Issues relating to text rendering/input label Mar 17, 2023
@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Mar 21, 2023

I don't see that message actually. I see:

  • Encountered stub: AVM2 flash.system.Security.loadPolicyFile()
  • 2 x DefineFont4 tag (TLF text) is not implemented
  • 7 x Symbol class ch1_fla.Font_<#> cannot be assigned to invalid character id <#>
  • Encountered stub: AVM2 flash.utils.Dictionary constructor with weak keys
  • Got RustError("ArgumentError: Child not a valid display object") when constructing AVM2 side of movie clip of type fl.video::FLVPlayback
  • Encountered stub: AVM2 flash.display.InteractiveObject.tabIndex setter
  • Encountered stub: AVM2 XML.settings()
  • Got "ReferenceError: Error #1069: Property flash.text.engine::ContentElement not found on global and there is no default value.
  • Encountered stub: AVM2 flash.display.Loader.unloadAndStop()

@Lord-McSweeney
Copy link
Collaborator

Lord-McSweeney commented Apr 16, 2023

That message has reappeared now that #10694 is merged.

@Lord-McSweeney
Copy link
Collaborator

For issue 2, clicking the video names on FP does do a fullscreen for me (on the Debug Projector).

@danielhjacobs
Copy link
Contributor Author

For that one I noticed something in the log on web and it says something about a fullscreenTakeOver function.

@danielhjacobs
Copy link
Contributor Author

I'm not on my laptop right now to check exactly what it says but you can see it in the console log.

@danielhjacobs
Copy link
Contributor Author

danielhjacobs commented Nov 17, 2023

Latest messages:

Warnings:

WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.display.Loader.load() addChild at the correct time
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.system.Security.loadPolicyFile()
WARN core/src/library.rs:546 Unknown device font "Arial" (bold: true, italic: false)
WARN core/src/library.rs:546 Unknown device font "Noto Sans" (bold: true, italic: false)
WARN core/src/library.rs:546 Unknown device font "Arial" (bold: false, italic: false)
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.utils.Dictionary constructor with weak keys
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.system.Capabilities.os getter
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.display.InteractiveObject.needsSoftKeyboard setter
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.TextBlock.createTextLine()
WARN core/src/library.rs:546 Unknown device font "Times New Roman" (bold: false, italic: false)
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.textBlockBeginIndex getter
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.ascent getter
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.descent getter
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.validity getter
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.hasGraphicElement
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.getBaselinePosition()
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.validity setter
WARN core/src/avm2/globals/flash/display/display_object_container.rs:184 Display object container has no child with name __id1_
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.atomCount getter
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextLine.getAtomBounds()
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.text.engine.TextBlock.recreateTextLine()
WARN core/src/stub.rs:144 Encountered stub: AVM2 flash.display.Loader.unloadAndStop()

Error for number 1 and number 2 (both same stack trace after different initial message):

1) ERROR core/src/display_object/movie_clip.rs:2238 Got "TypeError: Error #1009: Cannot access a property or method of a null object reference. (accessing field: http://ns.adobe.com/textLayout/internal/2008::getEffectiveLineHeight)
2) ERROR core/src/avm2/events.rs:428 Error dispatching event EventObject(EventObject { type: "mouseDown", class: flash.events::MouseEvent, ptr: 0x147b610 }) to handler FunctionObject(FunctionObject { ptr: 0xf34880, name: Ok("flashx.textLayout.container::TextContainerManager/mouseDownHandler()") }) : TypeError: Error #1009: Cannot access a property or method of a null object reference. (accessing field: http://ns.adobe.com/textLayout/internal/2008::getEffectiveLineHeight)
	at flashx.textLayout.compose::TextFlowLine/http://ns.adobe.com/textLayout/internal/2008::getLineLeading()
	at flashx.textLayout.compose::BaseCompose/calculateLeadingParameters()
	at flashx.textLayout.compose::BaseCompose/finishComposeLine()
	at flashx.textLayout.compose::BaseCompose/fitLineToParcel()
	at flashx.textLayout.compose::ComposeState/composeNextLine()
	at flashx.textLayout.compose::BaseCompose/composeParagraphElementIntoLines()
	at flashx.textLayout.compose::BaseCompose/composeParagraphElement()
	at flashx.textLayout.compose::ComposeState/composeParagraphElement()
	at flashx.textLayout.compose::BaseCompose/composeBlockElement()
	at flashx.textLayout.compose::BaseCompose/composeInternal()
	at flashx.textLayout.compose::ComposeState/composeInternal()
	at flashx.textLayout.compose::BaseCompose/composeTextFlow()
	at flashx.textLayout.compose::ComposeState/composeTextFlow()
	at flashx.textLayout.compose::StandardFlowComposer/http://ns.adobe.com/textLayout/internal/2008::callTheComposer()
	at flashx.textLayout.compose::StandardFlowComposer/internalCompose()
	at flashx.textLayout.compose::StandardFlowComposer/updateToController()
	at flashx.textLayout.compose::StandardFlowComposer/updateAllControllers()
	at flashx.textLayout.container::TextContainerManager/updateContainer()
	at flashx.textLayout.container::TextContainerManager/http://ns.adobe.com/textLayout/internal/2008::convertToTextFlowWithComposer()
	at fl.text::SingleTextContainerManager/get textFlow()
	at fl.text::SingleTextContainerManager/convert()
	at fl.text::TLFTextField/http://ns.adobe.com/textLayout/internal/2008::addNextField()
	at fl.text::RuntimeManager/configureInstance()
	at fl.text::RuntimeManager/getInstanceForInfo()
	at fl.timeline::TimelineManager/getInstanceForInfoWithXns()
	at fl.timeline::TimelineManager/getInstance()
	at fl.motion::AnimatorBase/play()
	at fl.motion::AnimatorBase$/processCurrentFrame()
	at fl.motion::AnimatorFactoryBase/addTargetInfo()
	at ch1_fla::MainTimeline()" when constructing AVM2 side of movie clip of type ch1_fla::MainTimeline

Error when double-clicking text beneath map:

ERROR core/src/avm2/events.rs:428 Error dispatching event EventObject(EventObject { type: "doubleClick", class: flash.events::MouseEvent, ptr: 0x1478128 }) to handler FunctionObject(FunctionObject { ptr: 0xf4b620, name: Ok("flashx.textLayout.container::TextContainerManager/mouseDoubleClickHandler()") }) : TypeError: Error #1009: Cannot access a property or method of a null object reference. (accessing field: http://adobe.com/AS3/2006/builtin::charAt)
	at flashx.textLayout.elements::ParagraphElement/getCharAtPosition()
	at flashx.textLayout.elements::FlowElement/getCharCodeAtPosition()
	at flashx.textLayout.elements::ParagraphElement/findNextWordBoundary()
	at flashx.textLayout.edit::SelectionManager/mouseDoubleClickHandler()
	at flashx.textLayout.container::ContainerController/mouseDoubleClickHandler()
	at flashx.textLayout.container::TextContainerManager/mouseDoubleClickHandler()

@danielhjacobs danielhjacobs removed the xml label Nov 30, 2023
@danielhjacobs danielhjacobs changed the title Issues on http://new.weedtowonder.org/introduction.html Issues on https://new.weedtowonder.org/introduction.html Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) bug Something isn't working flex Issues relating to Adobe Flex text Issues relating to text rendering/input tlf Issues relating to TLF text rendering or the TLF APIs in AVM2 unimplemented Issues for functionality that hasn't been implemented yet
Projects
None yet
Development

No branches or pull requests

4 participants