-
-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to create VAO #1905
Comments
I've blanked out the URL since this is an internal dashboard running Open Flash Charts. Possibly related to #1744, but this is a newer build. |
Issue occurs under Safari, Chrome, and Edge. Not an issue for Firefox. |
Thanks for the report! Could you paste the full log from the developer console on Chrome? (F12) |
Sure thing. Here's Chrome running the latest Ruffle nightly:
|
A new example of this came in today. It was initially tested with the Chrome store build, but it also still happens on the nightlies. Last replicated with Chrome extension build 9/12/21. It seems that there are simply too many SWFs loading on this page at once and core just sort of overloads and goes into a panic. When I load individual files, it's fine. |
Closed a bunch of duplicate issues with this. Let's keep this as the primary issue. We should figure out a) what situations this tends to happen on, and b) how to fail more gracefully. It seems like this is happening later on in execution, because a failure to create a VAO in Ruffle's startup should fallback to the canvas renderer. I guess the hardware is hitting a max VAO limit or similar(?). Maybe it'd be possible to completely restart Ruffle using the canvas renderer in this case. |
I've found one case where the crash happens (that @sombraguerrero actually already mentioned): when at least 17 SWF files are loaded at the same time, as it's not possible to have more than 16 WebGL contexts in a same tab in Chrome (could this value change depending on the device?). Here's a demonstration:
I think that fixing #6131 (comment) could indirectly help for some of these VAO issues we had as most pages probably don't intend to show so many SWFs at once. #4925 could also be game changer. |
Looking briefly through the latest batch of these, mostly failures in shape registration (either font glyphs or drawing API). Those ones are probably hitting some internal limit on VAOs (running out of video memory?) depending on a specific GPU -- I suspect a lot of these are old integrated GPUs. Still needs investigation:
|
Error Info
Error name: Error
Error message: panicked at 'called
Result::unwrap()
on anErr
value: "Unable to create VAO"', render/webgl/src/lib.rs:465:50Error stack:
Player Info
Allows script access: false
Page Info
Page URL: http://XXXXXXXXXX/admin/exec_dash/
Browser Info
Useragent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.1 Safari/605.1.15
OS: MacIntel
Ruffle Info
Version: 0.1.0
Name: nightly 2020-12-08
Channel: nightly
Built: 2020-12-08T00:33:37.383Z
Commit: 457d707
The text was updated successfully, but these errors were encountered: