The terms on http://www.dnai.org/glossary/ aren't showing definitions when clicked

[danielhjacobs]

Describe the bug

When clicking any term, you see the word "hi". For ease of accessing the link, I will rewrite the website from the issue title: http://www.dnai.org/glossary/

Expected behavior

e.g.: You are supposed to see the definition "One of the four bases that make up DNA. Abbreviated with an 'A.'" when clicking "Adenine".

Affected platform

Self-hosted version

Operating system

Linux Fedora 34 (64-bit)

Browser

Mozilla Firefox 93

Additional information

Despite the "Affected Platform" being "Self-hosted version" and the self-hosted version being somewhat out-of-date, I did try the latest extension as well (ensuring it took priority), and the same issue is still present.

Looking at the source code of http://www.dnai.org/glossary/glossary.swf in JPEXS, I see heavy use of _root, _parent, and _global. Possibly #768, or something related to iterating over "this"?

In DefineSprite (48: glossaryMC): frame1: DoAction (path based on JPEXS tags):

a = new Object();
a.Adenine = "One of the four bases that make up DNA.  Abbreviated with an \'A.\'";
a.Allele = "An alternate version of a gene, e.g., Gregor Mendel\'s pea plants have flowers with two colors: white and reddish-purple.  The flower color gene in this case has two alleles, one for white and the other for reddish-purple.";
a["Amino acids"] = "A class of molecules that are the building blocks of proteins.  There are 20 different amino acids used to make up proteins.";
...
z = new Object();
z.Zygote = "Refers to the cell formed by the union of two gametes; more broadly, refers to the organism that develops from such a cell.";
_global.glossary = new Object();
_global.temp = new Object();
for(aa in this)
{
   _global.temp[aa] = this[aa];
   _global.glossary[aa] = new Object();
   for(ab in _global.temp[aa])
   {
      _global.glossary[aa][ab] = _global.temp[aa][ab];
   }
   delete this.aa;
}
delete _global.temp;

[Toad06]

I've added some trace() in the code you mentioned and everything looks ok, all the variables are set correctly.

I rather think the issue is in \DefineSprite (42: bigDescriptionMC)\frame 1\DoAction. A few observations:

• If you replace this["descriptionMC" + ctr].label with this["descriptionMC" + ctr].fake for instance, you will get "hi" in Flash too which makes sense since label is the variable name used in \texts\DefineEditText(15).

• If you add trace(this["descriptionMC" + ctr].label); after this["descriptionMC" + ctr].label = ..., you get the same (and expected) values in Flash and Ruffle. If you add it before this line, Flash traces "hi" (the default value) but Ruffle traces "undefined".

This sounds similar to #2181 (also possibly to #4088).

[danielhjacobs]

Fixed by #12541