Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annoying sound issues BEE BOXING #5923

Closed
flashliberty5467 opened this issue Dec 25, 2021 · 3 comments · Fixed by #9447
Closed

annoying sound issues BEE BOXING #5923

flashliberty5467 opened this issue Dec 25, 2021 · 3 comments · Fixed by #9447
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working

Comments

@flashliberty5467
Copy link

Describe the bug

just play the game and we have the issues with sound

but otherwise the game works just fine

screen-capture.mp4

https://www.bubblebox.com/play/95/bee-boxing.htm

Expected behavior

for the game to play without annoying sounds as it is in order to enjoy the game i have to mute my chromebook

Affected platform

Browser's extension

Operating system

ChromeOS

Browser

Version 96.0.4664.111 (Official Build) (64-bit)

Additional information

No response

@flashliberty5467 flashliberty5467 added the bug Something isn't working label Dec 25, 2021
@relrelb
Copy link
Contributor

relrelb commented Dec 25, 2021

Thanks for the report! Unfortunately, this doesn't reproduce for me in the latest nightly (2021-12-22). Could it be that you just use an older release? (I suspect this has been fixed by #5657, which first landed in nightly 2021-11-28)

@flashliberty5467
Copy link
Author

flashliberty5467 commented Jan 15, 2022

@relrelb i just updated the extension to the latest vershion today and i still have the same issues mine now is (2022-01-15)

screen-capture.mp4

unfortunately #5657 did not fix my issues

@relrelb
Copy link
Contributor

relrelb commented Jan 16, 2022

After a short investigation, this looks like another case of #993 (comment).
In frame 5\DoAction:

if (this.kia == true) {
    this.lieDown = this.lieDown + 1;
    if (this.lieDown >= 10) {
        var _loc4_ = aktie.getNextHighestDepth();
        var _loc3_ = aktie.attachMovie("mcKruis","kruis" + _loc4_,_loc4_);
        _loc3_._x = this._x;
        _loc3_._y = this._y;
        _loc3_.kruisnr = this.commander.commanderNr;
        if (this.commander.control == true) {
            if (winnaar == null) {
                speelSimpelSFX("man_lost");
            }
        }
        this.kia = false; // <-- Added manually!!!
        this.removeMovieClip();
    }
}

In Flash, this.removeMovieClip() causes this.kia to be undefined in the next frames, preventing more instances of mcKruis (the cross) from being created.
In Ruffle, however, this.kia remains true, so new mcKruis instances keep getting created on each frame. Manually adding this.kia = false seems to solve the problem.
Will be fixed by #5492.

@relrelb relrelb added the A-avm1 Area: AVM1 (ActionScript 1 & 2) label Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants