Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dinogeddon: Colors are incorrect on last frame #9304

Closed
n0samu opened this issue Jan 25, 2023 · 4 comments
Closed

Dinogeddon: Colors are incorrect on last frame #9304

n0samu opened this issue Jan 25, 2023 · 4 comments
Labels
A-rendering Area: Rendering & Graphics bug Something isn't working regression Something was working before, but is now broken

Comments

@n0samu
Copy link
Member

n0samu commented Jan 25, 2023

Describe the bug

Link to SWF: https://www.dolldivine.com/games/dinogeddon-premNoGallery.swf

In Dinogeddon, Ruffle renders the colors incorrectly on the last frame of the menu. The colors are correct on all of the other frames.

Steps to reproduce:

  1. Run the SWF file in Ruffle
  2. Click the right arrow button to start the game.
  3. Click the right arrow button repeatedly until you get to the last frame of the menu.

In Ruffle, it looks like this:
image

Expected behavior

The frame is supposed to look like this. The background colors are supposed to be the same as the previous frames. (Ignore the different-looking girl - her appearance is randomized)
image

Affected platform

Desktop app

Operating system

Windows 10

Browser

No response

Additional information

This seems to be a problem with Ruffle's implementation of the Overlay blend mode. The menu sprite is sprite 1908, and its last frame is frame 12. On that frame, there are 3 PlaceObject3 tags with the Overlay blend mode:
image
Changing their blend mode to Normal makes the problem go away. I think their blend mode is being applied to the entire screen instead of just the sprite they are placing.

Also, this seems like a similar issue to #4464. That game also uses PlaceObject3 tags with a blend mode (Erase).

@n0samu n0samu added bug Something isn't working A-rendering Area: Rendering & Graphics labels Jan 25, 2023
@Lord-McSweeney
Copy link
Collaborator

Lord-McSweeney commented Mar 20, 2023

Seems to be fixed in latest nightly.

@n0samu
Copy link
Member Author

n0samu commented Mar 21, 2023

Uh, no it's not

@n0samu n0samu reopened this Mar 21, 2023
@n0samu n0samu added the regression Something was working before, but is now broken label Apr 30, 2023
@n0samu
Copy link
Member Author

n0samu commented Apr 30, 2023

This is a regression; I've bisected it to commit 8db8e46 of #9096.

@n0samu
Copy link
Member Author

n0samu commented Jun 22, 2023

Fixed by #11674

@n0samu n0samu closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rendering Area: Rendering & Graphics bug Something isn't working regression Something was working before, but is now broken
Projects
None yet
Development

No branches or pull requests

2 participants