Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#819 Implement multiple rescore query #820

Merged
merged 5 commits into from
May 14, 2015
Merged

#819 Implement multiple rescore query #820

merged 5 commits into from
May 14, 2015

Conversation

ebuildy
Copy link
Contributor

@ebuildy ebuildy commented Apr 22, 2015

According Elastic documentation:

http://www.elastic.co/guide/en/elasticsearch/reference/1.4/search-request-rescore.html

Rescore query can be a query or an array of queries.

I am sending a PR right now that should fix this case.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.67%) to 84.17% when pulling 14a6f39 on ebuildy:patch-1 into cc60e8f on ruflin:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.67%) to 84.17% when pulling 14a6f39 on ebuildy:patch-1 into cc60e8f on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.67%) to 84.17% when pulling 14a6f39 on ebuildy:patch-1 into cc60e8f on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 84.9% when pulling 14a6f39 on ebuildy:patch-1 into cc60e8f on ruflin:master.

@ebuildy
Copy link
Contributor Author

ebuildy commented Apr 23, 2015

Hmm travis job seems failed because ES server:

index: /elastica_elasticatestaggregationtophitstest55379e02755ad/questions/1 caused UnavailableShardsException[[elastica_elasticatestaggregationtophitstest55379e02755ad][0] Primary shard is not active or isn't assigned to a known node. Timeout: [1m], request: org.elasticsearch.action.bulk.BulkShardRequest@7fe9d315]

Maybe a disk space issue.

@im-denisenko
Copy link
Contributor

@ebuildy it happens time to time. But you also broke php 5.3 support here.

@ebuildy
Copy link
Contributor Author

ebuildy commented Apr 23, 2015

Doh' You are rights, totally forgot about support old Php.
I have just fixed it. Thanks you,

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 84.75% when pulling 86b19f4 on ebuildy:patch-1 into cc60e8f on ruflin:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 84.75% when pulling 86b19f4 on ebuildy:patch-1 into cc60e8f on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 84.75% when pulling 86b19f4 on ebuildy:patch-1 into cc60e8f on ruflin:master.

@ruflin
Copy link
Owner

ruflin commented Apr 24, 2015

@ebuildy Could you add a brief integration test to make sure that it works as expected?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 84.79% when pulling b6c4719 on ebuildy:patch-1 into cc60e8f on ruflin:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 84.9% when pulling 1943b3b on ebuildy:patch-1 into cc60e8f on ruflin:master.

@ebuildy
Copy link
Contributor Author

ebuildy commented Apr 27, 2015

Yeaaahhh!

@ruflin
Copy link
Owner

ruflin commented Apr 29, 2015

@ebuildy Thanks for the addition, but as far as I can see this query never runs on an elasticsearch instance. Or am I missing something?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.38%) to 85.22% when pulling 8a50204 on ebuildy:patch-1 into cc60e8f on ruflin:master.

ruflin added a commit that referenced this pull request May 14, 2015
#819 Implement multiple rescore query
@ruflin ruflin merged commit ab5982a into ruflin:master May 14, 2015
@ruflin
Copy link
Owner

ruflin commented May 14, 2015

Merged, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants