Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Draft PRs to not lock state #1125

Open
kneemaa opened this issue Jul 22, 2020 · 5 comments
Open

Allow for Draft PRs to not lock state #1125

kneemaa opened this issue Jul 22, 2020 · 5 comments
Labels
feature New functionality/enhancement Stale

Comments

@kneemaa
Copy link

kneemaa commented Jul 22, 2020

#1007 brought back plans in draft PRs. Only downside is that plans in a draft PR lock the project so that a Open PR cannot plan.

Requested Solution

An option to enable/disable locking projects in a Draft PR.

Reasoning

Draft PRs can iterate quickly and having them reserve the lock prevents Open PRs from progressing

When working in a commonly updated directory, a draft PR is a great way to discuss changes before opening a PR. But when a Draft PR has the project/directory locked, Open PRs cannot progress.

@lkysow lkysow added the feature New functionality/enhancement label Jul 22, 2020
@lkysow
Copy link
Member

lkysow commented Jul 22, 2020

Note that if draft pr plans are enabled users can apply from those PRs too. So if you disabled locking you'd also want to disable applies.

@kneemaa
Copy link
Author

kneemaa commented Jul 22, 2020

@lkysow that's a good point, disabling applies would be good as well.

@ghostsquad
Copy link

yes please

@dupuy26
Copy link
Contributor

dupuy26 commented Jun 23, 2022

If your repo configuration has apply_requirements including "mergable" then applies would automatically be disabled for a draft PR (since draft PRs cannot be merged).

If there is a feature for managing draft PRs and locks, it would also be useful to have locks released when a PR changes from 'draft:false' to 'draft:true'.

@finnag finnag mentioned this issue Mar 28, 2023
1 task
@scallisterdd
Copy link

When apply_requirements include mergeable, it may also make sense to release existing locks once a PR is no longer mergeable as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement Stale
Projects
None yet
Development

No branches or pull requests

5 participants