atlantis plan does not do init -upgrade first

[dimisjim]

I had the impression that after #443 the upgrade flag is the default setting.

But after replanning, atlantis does not pick up the newest version of the module which is referenced via git.

[gezb]

I submitted #1651 which I think has caused this.

The logic is if .terraform.lock.hcl exists Atlantis assumes you want to lock the providers to the versions specified in the lock file as that is what the Dependency lock file is there for and so does not add -upgrade to the terraform init argument list.

I now see the issue with this for anyone not using the dependency locking feature in that the first time terraform init is run it will generate the lock file and the then subsequent re-planning will use the same lock file

Not sure of a good way of addressing this? Maybe check if .terraform.lock.hcl exists prior to the init - and if not add a step to delete it after the terraform init has been run if it exists?

[dimisjim]

Yes to your last question.

Atlantis behavior shouldn't change based on what it does in its untracked and unmonitored internal state. We do not keep the tf lock file, thus we expect atlantis not too.

[gezb]

I'll prepare a PR to fix this in the next few days

[jamengual]

closed by #1701