Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Slash in Project Name #327

Closed
osterman opened this issue Oct 25, 2018 · 5 comments
Closed

Support Slash in Project Name #327

osterman opened this issue Oct 25, 2018 · 5 comments
Labels
feature New functionality/enhancement

Comments

@osterman
Copy link

what

  • A project named foo/bar (e.g. web/terraform and web/cloudformation) breaks

why

  • b/c PLANFILE has an extra slash and directory doesn't exist

suggested fix

  • Normalize project name
@osterman
Copy link
Author

Unrelated, but similar problem: #319

@lkysow
Copy link
Member

lkysow commented Oct 26, 2018

Why won't the fix in #319 work? The planfile after that fix won't contain a /.

@osterman
Copy link
Author

Oh it might :-)

@lkysow
Copy link
Member

lkysow commented Oct 30, 2018

@osterman I just merged #338. Let me know if that fixes it. I should be creating a new release in the next couple days if you don't want to run off of master (although I guess you're running a fork so that doesn't matter 😄)

@lkysow lkysow added the waiting-on-response Waiting for a response from the user label Oct 30, 2018
@lkysow
Copy link
Member

lkysow commented Nov 6, 2018

I'm going to close this unless I hear otherwise since naming projects with a / is now supported.

@lkysow lkysow closed this as completed Nov 6, 2018
@lkysow lkysow removed the waiting-on-response Waiting for a response from the user label Nov 6, 2018
@lkysow lkysow added the feature New functionality/enhancement label Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

2 participants