Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container lookup breaks component unit tests #69

Closed
Bargs opened this issue Jul 21, 2015 · 7 comments
Closed

Container lookup breaks component unit tests #69

Bargs opened this issue Jul 21, 2015 · 7 comments

Comments

@Bargs
Copy link

Bargs commented Jul 21, 2015

All of my unit tests that use the moduleForComponent helper are currently failing on the container lookup in mobiletouch's EventDispatcher override (line 46). I think this must have started with the 1.4.11 release when that line was added. In the context of the unit test, this.container is undefined. Maybe I'm missing something, but the existence of this.container on the EventDispatcher seems to be undocumented so I'm not sure it can be relied upon.

I'm going to try to update ember-qunit and see if that fixes it, but I thought I should drop a note here as well.

@Bargs
Copy link
Author

Bargs commented Jul 21, 2015

Tried updating to the latest version of ember-qunit, no luck. Also tried updating to ember-cli v1.13.1 and running ember init, but that didn't help either.

Forgot to provide version numbers before:

Ember: 1.13.3
Ember Data: 1.13.5
Ember CLI: 1.13.1
ember-mobiletouch: 1.4.11
ember-qunit: 0.4.1

@ef4
Copy link

ef4 commented Jul 28, 2015

This will fix the issue once it ships in ember-qunit: emberjs/ember-test-helpers#90

@runspired
Copy link
Owner

👍

@Bargs
Copy link
Author

Bargs commented Jul 28, 2015

@ef4 Ah ha! Thank you. I see there's still some discussion on that PR, if you need someone to test anything out let me know.

@ef4
Copy link

ef4 commented Jul 28, 2015

@rwjblue has already released ember-qunit v0.4.7 with this fix.

(I'm pretty sure he's really an advanced Artificial Intelligence that needs no sleep or food. That guy we see at meetups is just his front man.)

@runspired
Copy link
Owner

confirm. He is most definitely the product of some alien or artificial intelligence.

@runspired
Copy link
Owner

Closing as this is an upstream problem being addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants