-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container lookup breaks component unit tests #69
Comments
Tried updating to the latest version of ember-qunit, no luck. Also tried updating to ember-cli v1.13.1 and running Forgot to provide version numbers before: Ember: 1.13.3 |
This will fix the issue once it ships in ember-qunit: emberjs/ember-test-helpers#90 |
👍 |
@ef4 Ah ha! Thank you. I see there's still some discussion on that PR, if you need someone to test anything out let me know. |
@rwjblue has already released ember-qunit v0.4.7 with this fix. (I'm pretty sure he's really an advanced Artificial Intelligence that needs no sleep or food. That guy we see at meetups is just his front man.) |
confirm. He is most definitely the product of some alien or artificial intelligence. |
Closing as this is an upstream problem being addressed. |
All of my unit tests that use the
moduleForComponent
helper are currently failing on the container lookup in mobiletouch's EventDispatcher override (line 46). I think this must have started with the 1.4.11 release when that line was added. In the context of the unit test,this.container
is undefined. Maybe I'm missing something, but the existence ofthis.container
on the EventDispatcher seems to be undocumented so I'm not sure it can be relied upon.I'm going to try to update ember-qunit and see if that fixes it, but I thought I should drop a note here as well.
The text was updated successfully, but these errors were encountered: