Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support symbols as Record keys #199

Closed
yuhr opened this issue Mar 24, 2021 · 1 comment · Fixed by #204
Closed

Support symbols as Record keys #199

yuhr opened this issue Mar 24, 2021 · 1 comment · Fixed by #204
Labels
breaking change upstream matter

Comments

@yuhr
Copy link
Collaborator

yuhr commented Mar 24, 2021 •
edited
Loading

Currently (at least 5.1.0), Record uses for..in syntax to loop over fields, this way properties with keys being symbols are just ignored. We should handle this, but I wonder if this is a kind of breaking change or just a bugfix... Anyway this will change current behaviour somehow, so it must be treated as a breaking change.
@yuhr
Copy link
Collaborator Author

yuhr commented Mar 25, 2021

By the way, the related TS feature will be out there about two months away: microsoft/TypeScript#42762, microsoft/TypeScript#26797. Maybe we should wait for it?

@yuhr yuhr mentioned this issue Mar 28, 2021
Merged
@yuhr yuhr closed this as completed in #204 Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change upstream matter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: support symbol-keyed properties of object validation yuhr/runtypes
1 participant
@yuhr