Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix a few spans without .entered() #17087

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

davidbarsky
Copy link
Contributor

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2024
@lnicola
Copy link
Member

lnicola commented Apr 17, 2024

I might have found a couple more, can you take a look?

@davidbarsky davidbarsky force-pushed the david/fix-some-tracing-spans branch from 9bafe9f to 5ba37f3 Compare April 17, 2024 16:44
@davidbarsky
Copy link
Contributor Author

oh, good catch! nice.

@Veykril
Copy link
Member

Veykril commented Apr 17, 2024

That might explain some confusing traces I've seen, thank you!
@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2024

📌 Commit 5ba37f3 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 17, 2024

⌛ Testing commit 5ba37f3 with merge 46702ff...

@lnicola
Copy link
Member

lnicola commented Apr 17, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 17, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 46702ff to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 17, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 46702ff to master...

@bors
Copy link
Contributor

bors commented Apr 17, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Apr 17, 2024

📌 Commit 5ba37f3 has been approved by lnicola

It is now in the queue for this repository.

@bors bors merged commit 46702ff into rust-lang:master Apr 17, 2024
11 checks passed
@bors
Copy link
Contributor

bors commented Apr 17, 2024

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@davidbarsky davidbarsky deleted the david/fix-some-tracing-spans branch April 17, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants